Add ESLint rule for BN imports #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolginRoman
reviewed
Sep 20, 2024
packages/eslint-config/index.js
Outdated
| "error", | ||
| { | ||
| name: "bn.js", | ||
| message: "We no longer use BN.js for big number calculations. Switch to using bignumber.js instead. Run npm run convert-bn to automatically switch BN to BigNumber in all folders" |
There was a problem hiding this comment.
since we use pnpm maybe we can stick to it?
RolginRoman
reviewed
Sep 20, 2024
| @@ -1 +1 @@ | |||
| export * as StreamflowDistributorSolana from "./solana"; | |||
| export * as StreamflowDistributorSolana from "./solana/index.js"; | |||
There was a problem hiding this comment.
you said you were planning to migrate scoped exports here, do I miss anything here?
There was a problem hiding this comment.
I gave up on that - there are issues with v7 even with that, right now I paused that work in favour of more prio work (aligned unlocks/airdrops)
RolginRoman
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run convert-bnto run on all files underpackagesor you can specify the folders e.gnpm run convert-bn -- packages/stream/solana