Pin gRPC version for all the modules (#116)

streamnative · Jan 25, 2024 · 429e1b1 · 429e1b1
1 parent 14d137b
commit 429e1b1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/client/pom.xml b/client/pom.xml
@@ -31,7 +31,6 @@
 
     <properties>
         <caffeine.version>3.1.4</caffeine.version>
-        <grpc.version>1.59.0</grpc.version>
         <grpc-test.version>1.2.2</grpc-test.version>
         <javax.annotation.version>1.3.2</javax.annotation.version>
         <protobuf.version>3.25.0</protobuf.version>
@@ -40,18 +39,6 @@
         <zah.version>0.16</zah.version>
     </properties>
 
-    <dependencyManagement>
-        <dependencies>
-            <dependency>
-                <groupId>io.grpc</groupId>
-                <artifactId>grpc-bom</artifactId>
-                <version>${grpc.version}</version>
-                <type>pom</type>
-                <scope>import</scope>
-            </dependency>
-        </dependencies>
-    </dependencyManagement>
-
     <dependencies>
         <dependency>
             <groupId>com.github.ben-manes.caffeine</groupId>

diff --git a/pom.xml b/pom.xml
@@ -64,6 +64,8 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 
+        <grpc.version>1.59.0</grpc.version>
+
         <assertj.version>3.24.1</assertj.version>
         <awaitility.version>3.0.0</awaitility.version>
         <checkstyle.version>10.12.5</checkstyle.version>
@@ -87,6 +89,13 @@
 
     <dependencyManagement>
         <dependencies>
+            <dependency>
+                <groupId>io.grpc</groupId>
+                <artifactId>grpc-bom</artifactId>
+                <version>${grpc.version}</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>
             <dependency>
                 <groupId>io.opentelemetry</groupId>
                 <artifactId>opentelemetry-bom</artifactId>