Add kinesis sink 3.0 docs. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shibd, does it make sense to use a Google doc to facilitate the review? It would be efficient to comment and suggest changes there. |
But using Google Docs would lose our review process. |
Just like the SN connector docs we are improving/reviewing, using the Google doc can host the initial review to get a solid draft. Then we can start to use a pull request to host the final review and signoff. We can attach the G-doc link in the PR, so that all the historical comments can be traced back. |
|
Sure, I put this docs on here |
RobertIndie
reviewed
Aug 14, 2023
RobertIndie
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.