Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete *.yaml for manually doc connectors #458

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

shibd
Copy link
Member

@shibd shibd commented Oct 28, 2024

For manual docs of connectors, don't add *.yaml, otherwise, the auto upgrade version script will not work.

please refer to:

pulsar-hub/auto-upgrade.js

Lines 128 to 136 in 425ec23

async function autoUpgradeDocs() {
const needSyncYamlFiles = await globby(needSyncYamlPatterns);
const allDocMdFiles = await globby(allDocYamlPatterns);
const syncExternalFiles = await globby(syncExternalPatterns);
const needSyncYamlDirs = new Set(needSyncYamlFiles.map(file => path.dirname(file).split(path.sep).slice(0, 2).join(path.sep)));
const allDocMdDirs = new Set(allDocMdFiles.map(file => path.dirname(file).split(path.sep).slice(0, 2).join(path.sep)));
const syncExternalDirs = new Set(syncExternalFiles.map(file => path.dirname(file).split(path.sep).slice(0, 2).join(path.sep)));
const manuallyMaintainedConnectors = new Set([...allDocMdDirs].filter(dir => !needSyncYamlDirs.has(dir)).filter(dir => !syncExternalDirs.has(dir)));

@shibd shibd requested a review from nlu90 as a code owner October 28, 2024 01:45
@shibd shibd self-assigned this Oct 28, 2024
@shibd shibd merged commit 8ccbc88 into master Oct 28, 2024
1 check passed
@shibd shibd deleted the fix_manually_docs branch October 28, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant