Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting stretch Kafka cluster with Strimzi #129

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Supporting stretch Kafka cluster with Strimzi #129

wants to merge 9 commits into from
+366 −1

Commits on Nov 18, 2024

  1. MirrorMaker Connector Offsets Support (strimzi#127) 

    * MirrorMaker Connector Offsets Support

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Address scholzj review comments

* Clarify motivation wording.
* Move ConfigMap configuration to connector
level property.

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Scale back validation and allow multiple connectors

* Scale back the validation of input for
altering offsets to only validate the JSON
is syntactically correct, rather than validating
fields.

* Allow multiple connectors to be selected using
the mirrormaker-connector annotation.

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Address scholzj review comments

* Replace -> with -- in ConfigMap entry name.
* Add rejected alternatives section about
preventing users altering/reseting offsets for
MirrorCheckpointConnector and MirrorHeartbeatConnector.

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Update proposal to require single connector specified

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Address scholzj review comment

* Remove comma separated connector name example

Co-authored-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Kate Stanley <11195226+katheris@users.noreply.github.com>

* Address mimaison review comments

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Address PaulRMellor review comments

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>

* Prepare for merging

Signed-off-by: Jakub Scholz <www@scholzj.com>

---------

Signed-off-by: Katherine Stanley <11195226+katheris@users.noreply.github.com>
Signed-off-by: Kate Stanley <11195226+katheris@users.noreply.github.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
Co-authored-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Aswin A <aswin6303@gmail.com>
    @katheris @scholzj @aswinayyolath
    2 people authored and aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    37cfda4 View commit details
    Browse the repository at this point in the history

  2. This proposal describes design details of stretch cluster 

    Signed-off-by: Aswin A <aswin6303@gmail.com>
    @aswinayyolath
    aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b3ee8b2 View commit details
    Browse the repository at this point in the history

  3. updated design images 

    Signed-off-by: Aswin A <aswin6303@gmail.com>
    @aswinayyolath
    aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f65bc6e View commit details
    Browse the repository at this point in the history

  4. updated Motivation section to add more details 

    Signed-off-by: Aswin A <aswin6303@gmail.com>
    @aswinayyolath
    aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4d6ebe2 View commit details
    Browse the repository at this point in the history

  5. fix: Moved sentences to separate lines 

    Moved sentences to separate lines to help with reviews

Signed-off-by: neeraj-laad <neeraj.laad@uk.ibm.com>
Signed-off-by: Aswin A <aswin6303@gmail.com>
    @neeraj-laad @aswinayyolath
    neeraj-laad authored and aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ec6ca66 View commit details
    Browse the repository at this point in the history

  6. Added details about how to use Submariner for cross cluster communica… 

    …tion

Added details about how to use Submariner for cross cluster communication

Contributes to: strimzi#129

Signed-off-by: Aswin A <aswin6303@gmail.com>
    @aswinayyolath
    aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6d53f0a View commit details
    Browse the repository at this point in the history

  7. chore: Editorial fixes 

    Editorial fixes

Signed-off-by: neeraj-laad <neeraj.laad@gmail.com>
Signed-off-by: Aswin A <aswin6303@gmail.com>
    @neeraj-laad @aswinayyolath
    neeraj-laad authored and aswinayyolath committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    124b0b1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into stretch-cluster 

    Signed-off-by: Aswin A <55191821+aswinayyolath@users.noreply.github.com>
    @aswinayyolath
    aswinayyolath authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    924daa3 View commit details
    Browse the repository at this point in the history

  9. Update README.md 

    Signed-off-by: Aswin A <55191821+aswinayyolath@users.noreply.github.com>
    @aswinayyolath
    aswinayyolath authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5e6e440 View commit details
    Browse the repository at this point in the history