This repository has been archived by the owner on Jan 10, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 685
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #216 from stripe/jenan-github-templates
Add contributing docs, add issue and PR templates, and update README.
- Loading branch information
Showing
4 changed files
with
49 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
Thanks for your interest in contributing! | ||
|
||
## Filing issues | ||
|
||
`jQuery.payment` is not currently accepting feature requests. We _are_ interested in fixing bugs and updating credit card BINs where appropriate. Please file issues for these items only. | ||
|
||
When filing bugs, make sure to follow the issue template. When reporting credit card BIN changes, please include links to supporting documentation. | ||
|
||
## Submitting pull requests | ||
|
||
We will happily review and merge pull requests for bugs and card number changes. When submitting a pull request: | ||
|
||
- Ensure that the code and commit message are well-commented and grammatically correct. | ||
- Follow the style of the rest of the code, where possible. | ||
- Make sure that your diff is the minimal set of changes necessary to fix the bug in question. | ||
- Follow the pull request template. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
## Expected behavior | ||
|
||
Describe the expected behavior. For new credit card BIN numbers, please include supporting references. | ||
|
||
## Actual behavior | ||
|
||
Describe the actual behavior. List all browsers affected, as specifically as possible (e.g. "Chrome 49.2623.112 on OS X 10.11.4", not just "Chrome"). | ||
|
||
## Steps to reproduce | ||
|
||
Describe steps to reproduce the problem. Please include a link to a minimal reproduction of the problem with jsfiddle (or similar tool) where possible. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
## Summary | ||
|
||
Simple summary of what was changed. | ||
|
||
## Motivation | ||
|
||
Why are you making this change? Please provide supporting references for new BIN numbers and links to minimal reproductions (e.g. with jsfiddle) when fixing bugs. | ||
|
||
## Testing | ||
|
||
How was the code tested? Be as specific as possible. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters