Add support for altering sequences #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-altering-sequences
branch
2 times, most recently
from
74454c6
to
1b2cde4
Compare
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-altering-sequences
branch
from
1b2cde4
to
32100a9
Compare
| @@ -640,6 +598,74 @@ var sequenceAcceptanceTests = []acceptanceTestCase{ | |||
| diff.MigrationHazardTypeDeletesData, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
It might make sense to include some test cases with NO MINVALUE and NO MAXVALUE, particularly when there's a type change? I'm not really sure what the behavior should be in that scenario since the defaults would change...
There was a problem hiding this comment.
Solid points. Added some test cases for those scenarios.
dandrew-stripe
approved these changes
Feb 19, 2024
bplunkett-stripe
deleted the
bplunkett/add-support-for-altering-sequences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for altering sequences
Motivation
Fixes #110
Testing
Tested with unit tests