Add test cases for functional indexes #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds test cases to cover functional indexes to ensure that we test them in perpetuity.
A callout: under the hood the apply generates with a type cast for the input to the lower function (which only accepts text not varchar) which is different from the user provided definition without the cast. I think this doesn't trip up the tests and is desirable behavior because in reality pg-schema-diff is diffing schema that's been applied and read from a test database, not the user provided schema, so that type cast is always present.
Let me know if those empty line cleanup diffs should be removed. That's something my editor did.
Motivation
We want to use functional indexes. pg-schema-diff already does, but it's preferable to ensure it's covered by tests.
Testing
CI