Fix issue with non-breaking space in IBP promo disclaimer (#9733)

stripe · Dec 3, 2024 · 1667ce6 · 1667ce6
1 parent e9b5f70
commit 1667ce6
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/paymentsheet/res/values/strings.xml b/paymentsheet/res/values/strings.xml
@@ -46,10 +46,10 @@
   <string name="stripe_paymentsheet_bacs_protection_mandate">Your payments are protected by the %s.</string>
   <!-- Text displayed on manage bank account screen when bank account details are not editable. -->
   <string name="stripe_paymentsheet_bank_account_details_cannot_be_changed">Bank account details cannot be changed.</string>
-  <!-- Text shown in the bank payment form when a promo is available and the user is paying, e.g. 'Get $5 back when you pay by bank. See terms' -->
-  <string name="stripe_paymentsheet_bank_payment_promo_for_payment"><![CDATA[Get %s back when you pay by bank. <a href=\"https://link.com/promotion-terms\">Seeu00A0terms</a>]]></string>
-  <!-- Text shown in the bank payment form when a promo is available and the user is setting up an account, e.g. 'Get $5 back when you pay by bank. See terms' -->
-  <string name="stripe_paymentsheet_bank_payment_promo_for_setup"><![CDATA[Get %s back when you pay for the first time with your bank. <a href=\"https://link.com/promotion-terms\">Seeu00A0terms</a>]]></string>
+  <!-- Text shown in the bank payment form when a promo is available and the user is paying, e.g. 'Get $5 back when you pay by bank. See terms'. Note that 'See terms' contains a non-breaking space. -->
+  <string name="stripe_paymentsheet_bank_payment_promo_for_payment"><![CDATA[Get %s back when you pay by bank. <a href=\"https://link.com/promotion-terms\">See&#160;terms</a>]]></string>
+  <!-- Text shown in the bank payment form when a promo is available and the user is setting up an account, e.g. 'Get $5 back when you pay by bank. See terms'. Note that 'See terms' contains a non-breaking space. -->
+  <string name="stripe_paymentsheet_bank_payment_promo_for_setup"><![CDATA[Get %s back when you pay for the first time with your bank. <a href=\"https://link.com/promotion-terms\">See&#160;terms</a>]]></string>
   <!-- Text displayed on manage card screen when card details are not editable. -->
   <string name="stripe_paymentsheet_card_details_cannot_be_changed">Card details cannot be changed.</string>
   <!-- Text displayed below a credit card entry form when the card will be saved to make future payments. -->

diff --git a/...lingDetailsCollectionScreenshotTest_testPromoDisclaimerSetupFlow[DarkTheme].png b/...lingDetailsCollectionScreenshotTest_testPromoDisclaimerSetupFlow[DarkTheme].png
diff --git a/...ingDetailsCollectionScreenshotTest_testPromoDisclaimerSetupFlow[LightTheme].png b/...ingDetailsCollectionScreenshotTest_testPromoDisclaimerSetupFlow[LightTheme].png
diff --git a/...n.ach_BillingDetailsCollectionScreenshotTest_testPromoDisclaimer[DarkTheme].png b/...n.ach_BillingDetailsCollectionScreenshotTest_testPromoDisclaimer[DarkTheme].png
diff --git a/....ach_BillingDetailsCollectionScreenshotTest_testPromoDisclaimer[LightTheme].png b/....ach_BillingDetailsCollectionScreenshotTest_testPromoDisclaimer[LightTheme].png