Fix EPMs return unknown instead of epm on payment events (#9908)

stripe · Jan 15, 2025 · 544ef90 · 544ef90
1 parent 4c5eaf1
commit 544ef90
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEvent.kt b/paymentsheet/src/main/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEvent.kt
@@ -472,12 +472,13 @@ internal sealed class PaymentSheetEvent : AnalyticsEvent {
         private fun analyticsValue(
             paymentSelection: PaymentSelection?
         ) = when (paymentSelection) {
-            PaymentSelection.GooglePay -> "googlepay"
+            is PaymentSelection.GooglePay -> "googlepay"
             is PaymentSelection.Saved -> "savedpm"
-            PaymentSelection.Link,
+            is PaymentSelection.Link,
             is PaymentSelection.New.LinkInline -> "link"
             is PaymentSelection.New -> "newpm"
-            else -> "unknown"
+            is PaymentSelection.ExternalPaymentMethod -> "epm"
+            null -> "unknown"
         }
 
         private fun formatEventName(mode: EventReporter.Mode, eventName: String): String {

diff --git a/...entsheet/src/test/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEventTest.kt b/...entsheet/src/test/java/com/stripe/android/paymentsheet/analytics/PaymentSheetEventTest.kt
@@ -707,7 +707,7 @@ class PaymentSheetEventTest {
         assertThat(
             newPMEvent.eventName
         ).isEqualTo(
-            "mc_complete_payment_unknown_success"
+            "mc_complete_payment_epm_success"
         )
         assertThat(
             newPMEvent.params
@@ -748,7 +748,7 @@ class PaymentSheetEventTest {
         assertThat(
             newPMEvent.eventName
         ).isEqualTo(
-            "mc_complete_payment_unknown_failure"
+            "mc_complete_payment_epm_failure"
         )
         assertThat(
             newPMEvent.params