Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3DS2 2.2 Device Data Requirements #9298

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

Twigz
Copy link
Collaborator

@Twigz Twigz commented Sep 19, 2024

Summary

Adds the new device data requirements to the SDK

Motivation

The new 2.2 version of the 3DS2 test plan requires these changes.

Testing

Verified using the 3ds2 test harness / web portal.
Updated and ran the tests in the playground.

  • Added tests
  • Modified tests
  • Manually verified

@Twigz Twigz requested review from a team as code owners September 19, 2024 22:10
@tjclawson-stripe
Copy link
Collaborator

CI is failing with some lint errors. You can run ./gradlew ktlint and ./gradlew detekt to auto-fix. Other test failures appear to be flakes that will re run on push

@tjclawson-stripe
Copy link
Collaborator

Still getting some lint failures in CI @Twigz

@tjclawson-stripe
Copy link
Collaborator

tjclawson-stripe commented Sep 26, 2024

./gradlew :3ds2sdk:lintRelease is failling due to Missing permissions required by TelephonyManager.isMultiSimSupported: android.permission.READ_PHONE_STATE`

@Twigz
Copy link
Collaborator Author

Twigz commented Sep 26, 2024

./gradlew :3ds2sdk:lintRelease is failling due to Missing permissions required by TelephonyManager.isMultiSimSupported: android.permission.READ_PHONE_STATE`

All 3 lint commands are now passing. But, CI still seems to be upset, unfortunately.

@tjclawson-stripe
Copy link
Collaborator

Run ./gradlew :3ds2sdk:apiDump. This should be the last one. I apologize that it gives these incrementally instead of all at once.

@Twigz Twigz merged commit b83e96d into feature/3ds2-2.2 Oct 1, 2024
10 of 13 checks passed
@Twigz Twigz deleted the feature/3ds2-2.2-device-information branch October 1, 2024 18:07
tjclawson-stripe added a commit that referenced this pull request Nov 19, 2024
* Allows for auto-submittal of the challenge if the view is OOB (#9078)

* 3DS2 Req 71 Implementation (#9077)

* Adds challenge no entry value for req 71

* Updates test

* Make "Y" a constant

* 3DS2 2.2 Device Data Requirements (#9298)

* Add device information updates

* Fixing up tests

* Fix test

* Linting

* Update DeviceDataFactoryImpl.kt

* Update 3ds2sdk.api

* 3DS2 Spec Updates (#9387)

* 3DS2 Analytics Delegate (#9430)

* Allows for auto-submittal of the challenge if the view is OOB

* Analytics implementation

* Update 3ds2sdk.api

* Fix issues

* Utilizing service loader

* Move AnalyticsProvider

* Update 3ds2sdk.api

* Adds landscape layout for challenge zone view

* Update LOA

* Update message version in 3ds2 playground

* Add RestrictTo annotations to public APIs

---------

Co-authored-by: Twig <Twigz@users.noreply.github.com>
Co-authored-by: Twig <aharris.1990@gmail.com>
Co-authored-by: reuben-stripe <107846296+reuben-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants