Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on material icons for modules that use it. #9342

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

All these modules reference implementation libs.compose.materialIcons, but didn't already have a declared dependency on it.

Motivation

Working on getting some pre work done for upgrading compose.

Copy link
Contributor

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

@jaynewstrom-stripe jaynewstrom-stripe added the accept-risky-change accept-risky-change label Sep 26, 2024
@jaynewstrom-stripe
Copy link
Collaborator Author

Added the risky change label. We explicitly use these in the samples. It's wrong to assume you get these transitively.

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ -187 B │   8.6 MiB │   8.6 MiB │ -24 B 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │   2.3 MiB │   2.3 MiB │   0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.6 KiB │  25.6 KiB │   0 B 
      res │ 933.6 KiB │ 933.6 KiB │    0 B │   1.5 MiB │   1.5 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │   2.9 MiB │   2.9 MiB │   +1 B │   2.9 MiB │   2.9 MiB │  +1 B 
    other │   196 KiB │   196 KiB │   -7 B │ 430.6 KiB │ 430.6 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  12.8 MiB │  12.8 MiB │ -193 B │  21.7 MiB │  21.7 MiB │ -23 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42624 │ 42624 │ 0 (+1 -1) 
   types │ 14127 │ 14127 │ 0 (+0 -0) 
 classes │ 11765 │ 11765 │ 0 (+0 -0) 
 methods │ 60354 │ 60354 │ 0 (+0 -0) 
  fields │ 40021 │ 40021 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6247 │ 6247 │  0
APK
    compressed     │   uncompressed    │                               
──────────┬────────┼───────────┬───────┤                               
 size     │ diff   │ size      │ diff  │ path                          
──────────┼────────┼───────────┼───────┼───────────────────────────────
  3.9 MiB │ -187 B │   8.6 MiB │ -24 B │ ∆ classes.dex                 
 53.4 KiB │   -8 B │ 118.3 KiB │   0 B │ ∆ META-INF/CERT.SF            
 50.1 KiB │   +2 B │ 118.2 KiB │   0 B │ ∆ META-INF/MANIFEST.MF        
  7.8 KiB │   +1 B │   7.7 KiB │  +1 B │ ∆ assets/dexopt/baseline.prof 
  1.2 KiB │   -1 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼───────────┼───────┼───────────────────────────────
    4 MiB │ -193 B │   8.8 MiB │ -23 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42624 │ 42624 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:f62423a,r8-mode:full,version:8.5.35}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:ab50aa9,r8-mode:full,version:8.5.35}

@jaynewstrom-stripe jaynewstrom-stripe merged commit b0f1538 into master Sep 26, 2024
18 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/material-icons branch September 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accept-risky-change accept-risky-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants