-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable TestWeChatPay #9348
Re-enable TestWeChatPay #9348
Conversation
Diffuse output:
APK
|
10dea2a
to
5e3d765
Compare
) { | ||
override fun click() { | ||
if (testParameters.paymentMethodCode == "wechat_pay") { | ||
wait(5000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use a compose.waitUntil here instead of a hard-coded delay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you do this, then maybe you could just unconditionally add this, instead of having to add it just for wechat pay. And then we won't see issues like this for other LPMs in the future (if it started happening for other LPMs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because the web view isn't compose based
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. Do we want to add a potentially unnecessary delay for all e2e test though?
Summary
Add delay before checking for UI Elements for WeChat pay tests
Motivation
Fix WeChat tests
Testing
Screenshots