Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CardElement Activity tests #9349

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

tjclawson-stripe
Copy link
Collaborator

Summary

Add tests that attempt to display CardFormView, CardMultilineWidget, and CardInputWidget on a base Activity.

Motivation

Ensure LifecycleOwnerDelegate properly stubs required AndroidX dependencies

Testing

  • Added tests
  • Modified tests
  • Manually verified

samer-stripe
samer-stripe previously approved these changes Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff  
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
      dex │   3.9 MiB │   3.9 MiB │ -89 B │   8.6 MiB │   8.6 MiB │ +12 B 
     arsc │   2.3 MiB │   2.3 MiB │   0 B │   2.3 MiB │   2.3 MiB │   0 B 
 manifest │   5.1 KiB │   5.1 KiB │   0 B │  25.6 KiB │  25.6 KiB │   0 B 
      res │ 933.6 KiB │ 933.6 KiB │   0 B │   1.5 MiB │   1.5 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │     6 MiB │     6 MiB │   0 B 
    asset │   2.9 MiB │   2.9 MiB │  -2 B │   2.9 MiB │   2.9 MiB │  -2 B 
    other │   196 KiB │   196 KiB │  +3 B │ 430.6 KiB │ 430.6 KiB │   0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼───────
    total │  12.8 MiB │  12.8 MiB │ -88 B │  21.7 MiB │  21.7 MiB │ +10 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42635 │ 42635 │ 0 (+1 -1) 
   types │ 14134 │ 14134 │ 0 (+0 -0) 
 classes │ 11770 │ 11770 │ 0 (+0 -0) 
 methods │ 60378 │ 60378 │ 0 (+0 -0) 
  fields │ 40043 │ 40043 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6247 │ 6247 │  0
APK
    compressed    │   uncompressed    │                                           
──────────┬───────┼───────────┬───────┤                                           
 size     │ diff  │ size      │ diff  │ path                                      
──────────┼───────┼───────────┼───────┼───────────────────────────────────────────
  3.9 MiB │ -89 B │   8.6 MiB │ +12 B │ ∆ classes.dex                             
 50.1 KiB │  +3 B │ 118.2 KiB │   0 B │ ∆ META-INF/MANIFEST.MF                    
  7.9 KiB │  -2 B │   7.7 KiB │  -2 B │ ∆ assets/dexopt/baseline.prof             
    272 B │  +1 B │     120 B │   0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  -1 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼───────┼───────────────────────────────────────────
    4 MiB │ -88 B │   8.7 MiB │ +10 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42635 │ 42635 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3b1d132,r8-mode:full,version:8.5.35}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4737c42,r8-mode:full,version:8.5.35}

@tjclawson-stripe tjclawson-stripe merged commit ece9af2 into master Sep 27, 2024
14 of 16 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/card-element-tests branch September 27, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants