Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Link Button content descriptions #9350

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

amk-stripe
Copy link
Collaborator

Summary

Improve Link Button content descriptions

  • The old description for the signed in button read "icon divider underscore spacer divider underscore spacer link ". Now it reads "Pay with Link "
  • The old description for the signed out button read "Pay with [icon] Link", now it reads "Pay with Link"

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2164

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │          uncompressed          
          ├───────────┬───────────┬──────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff   
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ -3 B │   8.6 MiB │   8.6 MiB │ +360 B 
     arsc │   2.3 MiB │   2.3 MiB │  0 B │   2.3 MiB │   2.3 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │  0 B │  25.6 KiB │  25.6 KiB │    0 B 
      res │ 933.6 KiB │ 933.6 KiB │  0 B │   1.5 MiB │   1.5 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │    0 B 
    asset │   2.9 MiB │   2.9 MiB │ +1 B │   2.9 MiB │   2.9 MiB │   +1 B 
    other │   196 KiB │   196 KiB │ +7 B │ 430.6 KiB │ 430.6 KiB │    0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼────────
    total │  12.8 MiB │  12.8 MiB │ +5 B │  21.7 MiB │  21.7 MiB │ +361 B 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 42635 │ 42636 │ +1 (+8 -7)     
   types │ 14134 │ 14134 │  0 (+6 -6)     
 classes │ 11770 │ 11770 │  0 (+4 -4)     
 methods │ 60378 │ 60377 │ -1 (+719 -720) 
  fields │ 40043 │ 40040 │ -3 (+540 -543) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6247 │ 6247 │  0
APK
    compressed    │    uncompressed    │                                           
──────────┬───────┼───────────┬────────┤                                           
 size     │ diff  │ size      │ diff   │ path                                      
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
 53.4 KiB │ +11 B │ 118.3 KiB │    0 B │ ∆ META-INF/CERT.SF                        
    975 B │  +5 B │     843 B │   +5 B │ ∆ assets/dexopt/baseline.profm            
 50.1 KiB │  -5 B │ 118.2 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
  7.9 KiB │  -4 B │   7.7 KiB │   -4 B │ ∆ assets/dexopt/baseline.prof             
  3.9 MiB │  -3 B │   8.6 MiB │ +360 B │ ∆ classes.dex                             
    272 B │  +1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
    4 MiB │  +5 B │   8.8 MiB │ +361 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   42635 │ 42636 │ +1 (+8 -7) 
  
  + LB6/p;
  + LB6/q;
  + LD7/y;
  + LW5/y;
  + [LD7/k;
  + [LM8/U0;
  + invalid weight 0.5; must be greater than zero
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:fc74422,r8-mode:full,version:8.5.35}
  
  - LJ5/S;
  - LM8/C1;
  - LV5/N;
  - Ly0/f;
  - [LD7/j;
  - [LM8/V0;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c10cb6d,r8-mode:full,version:8.5.35}
  

TYPES:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   14134 │ 14134 │ 0 (+6 -6) 
  
  + LB6/p;
  + LB6/q;
  + LD7/y;
  + LW5/y;
  + [LD7/k;
  + [LM8/U0;
  
  - LJ5/S;
  - LM8/C1;
  - LV5/N;
  - Ly0/f;
  - [LD7/j;
  - [LM8/V0;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   60378 │ 60377 │ -1 (+719 -720) 
  
  + A0.i d0(i, String, int) → k1
  + A6.g a(boolean, a, v, int)
  + B1.i C(String) → k1
  + B6.j <init>(e1, boolean, int, m, c)
  + B6.l <clinit>()
  + B6.l L(Object) → Object
  + B6.m <init>(String, int)
  + B6.m L(Object) → Object
  + B6.n <init>(String, int, int)
  + B6.n J(Object, Object) → Object
  + B6.o <init>(int, int, Object)
  + B6.p <clinit>()
  + B6.p a(String, boolean, a, m, v, int)
  + B6.p b(int, v)
  + B6.p c(int, v)
  + B6.p d(int, v)
  + B6.p e(String, v, int)
  + B6.p f(T, v, int)
  + B6.q <init>(boolean, m, boolean, int, int)
  + B6.q <init>(boolean, boolean, m, int, int)
  + B6.q J(Object, Object) → Object
  + C.e d(f0, c, m, C, D, a, v, int)
  + C.e e(f0, e, m, C, D, a, v, int)
  + C.e f(u, boolean, m, C, D, String, a, v, int)
  + C.e g(boolean, m, C, D, String, a, v, int, int)
  + C.n0 <init>(L, g)
  + C.n0 C(String) → k1
  + C6.A <init>(i, e1, j0, e1, boolean, a, boolean, boolean, e, m, int)
  + C6.A <init>(boolean, boolean, a, boolean, e, i, e1, j0, e1, m, int)
  + C6.I <init>(String, i, e1, j0, e1, a, boolean, boolean, boolean, e, a, m, int, int, int)
  + C6.J <init>(m, e1, int, boolean, boolean, Integer, c, int, int)
  + C6.J <init>(boolean, e1, a, int, m, boolean, e, int, int)
  + C6.M <init>(f, e1, boolean, m, m, m, boolean, d)
  + C6.r <init>(Y, e, d0, boolean, int, a)
  + C6.u <init>(a, boolean, boolean, e1, a, boolean, m, j0, m, e1, m, e)
  + C6.v <init>(boolean, a, boolean, j0, m, e1, m, e, boolean, a, boolean, e1, m)
  + C6.w <init>(Integer, e1, j0, e1, a, boolean, boolean, boolean, e, boolean, a, m, m, m, m, int, int, int)
  + C6.z <init>(e1, j0, e1, a, boolean, boolean, e, Y, m, Y)
  + D5.G a(String, String, j3, f, t, u, v, w, d) → Object
  + D5.Y <init>(x, String, d)
  + D7.f c(x)
  + D7.g <init>(Object, Object, int, int)
  + D7.g J(Object, Object) → Object
  + D7.h <init>(int, boolean, boolean)
  + D7.h L(Object) → Object
  + D7.i k() → k
  + D7.j <init>(t)
  + D7.j c() → float
  + D7.j close()
  + D7.j d() → m0
  + D7.j f() → float
  + D7.j h(m, v, int)
  + D7.j i() → W
  + D7.j j() → float
  + D7.j k() → k
  + D7.j l() → boolean
  + D7.j m() → boolean
  + D7.j n(boolean) → m0
  + D7.j o(boolean, boolean) → m0
  + D7.k valueOf(String) → k
  + D7.k values() → k[]
  + D7.l <clinit>()
  + D7.l n() → Object
  + D7.m <init>(I)
  + D7.m k() → k
  + D7.n <init>(y)
  + D7.n close()
  + D7.n k() → k
  + D7.o <clinit>()
  + D7.o k() → k
  + D7.p <init>(n0)
  + D7.p k() → k
  + D7.q <init>(g)
  + D7.q c() → float
  + D7.q close()
  + D7.q d() → m0
  + D7.q f() → float
  + D7.q h(m, v, int)
  + D7.q i() → W
  + D7.q j() → float
  + D7.q k() → k
  + D7.q l() → boolean
  + D7.q m() → boolean
  + D7.q n(boolean) → m0
  + D7.q o(boolean, boolean) → m0
  + D7.r <clinit>()
  + D7.r equals(Object) → boolean
  + D7.r hashCode() → int
  + D7.r toString() → String
  + D7.s <init>(o0)
  + D7.u <init>(I, t)
  + D7.u close()
  + D7.u k() → k
  + D7.v <init>(q)
  + D7.v k() → k
  + D7.w <init>(t, boolean)
  + D7.w close()
  + D7.w k() → k
  + D7.x c() → float
  + D7.x d() → m0
  + D7.x f() → float
  + D7.x h(m, v, int)
  + D7.x i() → W
  + D7.x j() → float
  + D7.x k() → k
  + D7.x l() → boolean
  + D7.x m() → boolean
  + D7.x n(boolean) → m0
  + D7.x o(boolean, boolean) → m0
  + D7.y <clinit>()
  + D8.D C(String) → k1
  + D8.E1 <init>(i1, boolean, m, int, int)
  + D8.E <init>(P, W0, a)
  + D8.G C(String) → k1
  + D8.T1 <init>(u, boolean, m, C, D, String, a, int)
  + D8.T1 <init>(boolean, String, String, a, d, a, a, int)
  + D8.W0 C(String) → k1
  + D8.X0 <ini
...✂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really didn't intend to update the UI at all. I can't visually tell the difference between any of these, except if you use the swipe feature, you can see the the email is moved down the tiniest bit. I think this is because I added a Row to the SignedInButtonContent to set a content description. Lmk if I should rework the PR for this

@amk-stripe amk-stripe marked this pull request as ready for review September 26, 2024 23:30
@amk-stripe amk-stripe requested review from a team as code owners September 26, 2024 23:30
@amk-stripe amk-stripe merged commit 4260dad into master Sep 27, 2024
16 checks passed
@amk-stripe amk-stripe deleted the improve-link-button-content-descriptions branch September 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants