Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FC Maestro tests more resilient #9355

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

tillh-stripe
Copy link
Collaborator

Summary

This pull request attempts to make FC Maestro tests more resilient by using scrollUntilVisible for validating text on screen.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@tillh-stripe tillh-stripe marked this pull request as ready for review September 27, 2024 17:14
@tillh-stripe tillh-stripe requested review from a team as code owners September 27, 2024 17:14
@tillh-stripe tillh-stripe enabled auto-merge (squash) September 27, 2024 17:14
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@tillh-stripe tillh-stripe merged commit 47cb85c into master Sep 27, 2024
12 of 13 checks passed
@tillh-stripe tillh-stripe deleted the tillh/resilient-fc-maestro-tests branch September 27, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants