Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return CustomerEphemeralKey.Available directly rather than have consumers handle it. #9366

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Return CustomerEphemeralKey.Available directly rather than have consumers handle it. #9366

merged 1 commit into from
Sep 30, 2024

Conversation

samer-stripe
Copy link
Collaborator

Summary

Return CustomerEphemeralKey.Available directly rather than have consumers handle it in CachedCustomerEphemeralKey

Motivation

Ensures only an available key is returned to the caller.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe marked this pull request as ready for review September 30, 2024 21:04
@samer-stripe samer-stripe requested review from a team as code owners September 30, 2024 21:04
amk-stripe
amk-stripe approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@amk-stripe amk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks!

@samer-stripe samer-stripe merged commit d494776 into master Sep 30, 2024
10 checks passed
@samer-stripe samer-stripe deleted the samer/return-available-from-key-cs branch September 30, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amk-stripe amk-stripe amk-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samer-stripe @amk-stripe