Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILESDK-2894] [Android] Make Default Payment Method first #9928

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

tianzhao-stripe
Copy link
Contributor

@tianzhao-stripe tianzhao-stripe commented Jan 16, 2025

Summary

Added logic for putting the default payment method

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2894

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
Vertical Mode 1000000061 1000000058
Horizontal Mode 1000000062 1000000059

Changelog

N.A.

edge case where defaultPaymentMethodIndex not found and there is a saved selection Index, and we ignore the savedSelectionIndex
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │   0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.2 KiB │   7.2 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ -11 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -11 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19982 │ 19982 │ 0 (+0 -0) 
   types │  6194 │  6194 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17539 │ 17539 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │  -9 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │  -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.4 KiB │  +1 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 55.3 KiB │ -11 B │ 127.4 KiB │  0 B │ (total)

amk-stripe
amk-stripe previously approved these changes Jan 16, 2025
@tianzhao-stripe tianzhao-stripe merged commit 3a0e9e3 into master Jan 17, 2025
13 checks passed
@tianzhao-stripe tianzhao-stripe deleted the MOBILESDK-2894-Sorting branch January 17, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants