Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILESDK-2894] [Android] Make Default Payment Method selected #9932

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

tianzhao-stripe
Copy link
Contributor

@tianzhao-stripe tianzhao-stripe commented Jan 17, 2025

Summary

Added Logic for retrieving the initial payment selection
did some refactoring in DefaultPaymentElementLoaderTest to accomodate testing for selection

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2894

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
Vertical Mode 1000000061 1000000063
Horizontal Mode 1000000062 1000000065

Changelog

N.A.

Copy link
Contributor

github-actions bot commented Jan 17, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.2 KiB │   7.2 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ -2 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -2 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19982 │ 19982 │ 0 (+0 -0) 
   types │  6194 │  6194 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17539 │ 17539 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.4 KiB │ -3 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.5 KiB │ +2 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 55.1 KiB │ -2 B │ 127.3 KiB │  0 B │ (total)

@tianzhao-stripe tianzhao-stripe force-pushed the MOBILESDK-2894-Selection branch from 2158905 to 925d7c2 Compare January 17, 2025 17:26
@tianzhao-stripe tianzhao-stripe marked this pull request as ready for review January 17, 2025 18:10
@tianzhao-stripe tianzhao-stripe requested review from a team as code owners January 17, 2025 18:10
@tianzhao-stripe tianzhao-stripe merged commit 5e72691 into master Jan 17, 2025
13 checks passed
@tianzhao-stripe tianzhao-stripe deleted the MOBILESDK-2894-Selection branch January 17, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants