add justfile, update readme, remove coveralls #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
a team and
jar-stripe
and removed request for
a team
xavdid-stripe
commented
Jan 13, 2025
| env: | ||
| COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| COVERALLS_FLAG_NAME: Go-${{ matrix.go }} | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
this block is mostly the same except coveralls is gone and just is used in favor of make. The rest of the changes are that, prettier shifted it over (it was intended by 5 spaces?)
| echo "{{ version }}" > VERSION | ||
| perl -pi -e 's|const clientversion = "[.\d\-\w]+"|const clientversion = "{{ version }}"|' stripe.go | ||
|
|
||
| # go imports use the package's major version in the path, so we need to update them |
There was a problem hiding this comment.
This was the only especially tricky thing- we want major_version to be evaluated lazily, but also shared throughout the recipe.
This comment is probably too detailed, but I wanted to remind myself why I did it exactly this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In an effort to modernize and simplify our local tooling, we're moving our dev commands from makefiles to justfiles. This is intended to be mostly a drop-in replacement, but some command names may change per standardization efforts.
What?
See Also
DEVSDK-2325