Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update publish script to check for github token #519

Merged
merged 1 commit into from
Oct 24, 2023
Merged

update publish script to check for github token #519

merged 1 commit into from
Oct 24, 2023

Conversation

madhav-stripe
Copy link
Contributor

@madhav-stripe madhav-stripe commented Oct 23, 2023 •
edited by fruchtose-stripe
Loading

Summary & motivation

Adds a quick 'n easy check for our publish script to see if the GITHUB_TOKEN is set.

Testing & documentation

./scripts/publish minor
GITHUB_TOKEN is not set.

@madhav-stripe madhav-stripe requested review from pololi-stripe and fruchtose-stripe and removed request for pololi-stripe October 23, 2023 18:17
fruchtose-stripe
fruchtose-stripe approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@fruchtose-stripe fruchtose-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible, thank you!

@madhav-stripe madhav-stripe merged commit 2274d67 into master Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruchtose-stripe fruchtose-stripe fruchtose-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madhav-stripe @fruchtose-stripe