Add preferredNetwork option
#537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to do this when adding Link to split card
martinalong-stripe
changed the title
preferredNetwork optionpreferredNetwork option
keno-stripe
reviewed
Jan 11, 2024
|
|
||
| /** | ||
| * Applies a disabled state to the Element such that user input is not accepted. | ||
| * Default is false. |
There was a problem hiding this comment.
Suggested change
| * Default is false. | |
| * Default is `false`. |
to be consistent with other comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Adds a
preferredNetworkoption that can be passed uponcardandcardNumbercreate. The shape is an array of card networks.Also adds the
disableLinkoption on create tocardNumber. It had previously been added tocard, and it should've been added tocardNumberas well, but was forgotten.Testing & documentation
I wrote unit tests
Public documentation will be updated later on (feature is not yet released)