Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Add cordova as a peerdep? #1

Open
ritch opened this issue Nov 15, 2013 · 6 comments
Open

Add cordova as a peerdep? #1

ritch opened this issue Nov 15, 2013 · 6 comments

Comments

@ritch
Copy link

ritch commented Nov 15, 2013

After installing bacn and creating a project. Running bacn build complains about cordova. Is it possible to have cordova installed alongside bacn?

Ω bacn build
[Error: No platforms added! `cordova platform add <platform>` to add a platform.]
Finished.
Ω cordova
bash: cordova: command not found
@Schoonology
Copy link
Contributor

bacn build complained because we failed to add iOS as a client platform. This is most likely because you're missing the SDK. If there's one thing that's lacking in bacn, it's error messaging.

Cordova is not installed as a peer dependency to not conflict with existing installs (see our conversation from the npm-ized CLI discussion). We require a specific version of cordova that we know works and works with our generated code.

@seanbrookes
Copy link
Contributor

fwiw I ended up running the following plugins as well to get up and running yesterday. Will those also come with inclusion of the iOS platform?

cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-device.git
cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-network-information.git
cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-console.git
cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation.git
cordova plugin add https://git-wip-us.apache.org/repos/asf/cordova-plugin-storage.git

@Schoonology
Copy link
Contributor

They should, yes.

On Fri, Nov 15, 2013 at 6:27 PM, Sean Brookes notifications@github.comwrote:

fwiw I ended up running the following plugins as well to get up and
running yesterday. Will those also come with inclusion of the iOS platform?

cordova plugin add
https://git-wip-us.apache.org/repos/asf/cordova-plugin-device.git
cordova plugin add
https://git-wip-us.apache.org/repos/asf/cordova-plugin-network-information.git
cordova plugin add
https://git-wip-us.apache.org/repos/asf/cordova-plugin-console.git
cordova plugin add
https://git-wip-us.apache.org/repos/asf/cordova-plugin-geolocation.git
cordova plugin add
https://git-wip-us.apache.org/repos/asf/cordova-plugin-storage.git


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-28612072
.

@sam-github
Copy link

Can't you specify the specific version you depend on in the peerDep?

@Schoonology
Copy link
Contributor

I'm not sure how that interacts with existing installs, but I suppose that can be investigated. The surprise for most people will be that we only support a specific version, 2.8, and none newer than that.

@sam-github
Copy link

With existing, I'd expect it to warn you that its not compatible. My
expectations of npm are not always met. Anyhow, I'm just kibitzing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants