Merge pull request #14 from stscoundrel/feature/common-vendors

Feature/common vendors

src/ignores/index.ts

@@ -1,10 +1,17 @@
 const DEFAULT_IGNORES = [
   '.git',
   '.github',
+];
+
+const VENDOR_IGNORES = [
   'node_modules',
+  'bower_components',
+  'vendor',
 ];
 
-export const getDefaultIgnores = (): string[] => DEFAULT_IGNORES;
+const IGNORES = [...DEFAULT_IGNORES, ...VENDOR_IGNORES];
+
+export const getDefaultIgnores = (): string[] => IGNORES;
 
 export const doesNotContainIgnores = (
   path: string,

tests/fixtures/index.cs

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/index.js

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/index.py

@@ -0,0 +1,5 @@
+# For Balder the mead, a drink for the noble
+# I was forced to speak, now silence is my name
+
+# Hod shall guide him, shall be his bane
+# I was forced to speak, now silence is my name

tests/fixtures/index.rs

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/index.ts

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/subfolder1/submodule.ts

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/subfolder1/submodule2.js

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/subfolder2/subfolder2-3/submodule.ts

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/subfolder2/submodule.js

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/vendors/bower_components/bower.c

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/fixtures/vendors/vendor/vendor.m

@@ -0,0 +1,5 @@
+// For Balder the mead, a drink for the noble
+// I was forced to speak, now silence is my name
+
+// Hod shall guide him, shall be his bane
+// I was forced to speak, now silence is my name

tests/unit/ignores.test.ts

@@ -12,4 +12,11 @@ describe('Alliser ignore tests', () => {
     result.forEach((filePath) => expect(filePath.includes('.git')).toBeFalsy());
     result.forEach((filePath) => expect(filePath.includes('.github')).toBeFalsy());
   });
+
+  test('Does not scan common vendor folders', () => {
+    const result = alliser.check(['.ts'], ['./tests/fixtures/vendors']);
+
+    // We expect no files to be found here, as its all vendor folders.
+    expect(result.length).toBe(0);
+  });
 });