fix: required input is correctly parsed

stumpam · Feb 27, 2022 · f54726b · f54726b
1 parent 0933265
commit f54726b
Show file tree

Hide file tree

Showing 5 changed files with 298 additions and 596 deletions.
diff --git a/libs/ngx-cz-id/package.json b/libs/ngx-cz-id/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@stumpam/ngx-cz-id",
   "license": "MIT",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "description": "Angular input for czech id (Rodné číslo) with validation.",
   "homepage": "https://github.com/stumpam/ngx-cz-id",
   "author": "Martin Štumpa (https://github.com/stumpam)",

diff --git a/libs/ngx-cz-id/src/lib/directives/input/input.directive.ts b/libs/ngx-cz-id/src/lib/directives/input/input.directive.ts
@@ -1,3 +1,4 @@
+import { BooleanInput, coerceBooleanProperty } from '@angular/cdk/coercion';
 import {
   ChangeDetectorRef,
   Directive,
@@ -41,11 +42,9 @@ const nextYear = new Date().getFullYear() - 1999;
 
 @Directive({
   selector: '[ngxCzId]',
-  // tslint:disable-next-line: no-host-metadata-property
   host: {
     '(blur)': 'onBlur()',
     '(input)': 'onInput($event.target.value)',
-    '[class.ngx-date-input]': 'true',
   },
   providers: [ID_VALUE_ACCESSOR, ID_VALUE_VALIDATOR],
 })
@@ -55,14 +54,22 @@ export class IdInputDirective
   @Input() min: number | undefined;
   @Input() max: number | undefined;
   @Input() options: CzIdOptions;
-  @Input() required: boolean;
   /**
    * Validation uses your RegExp and min/max validation for age.
    * Validation for correctness of ID (Rodné číslo) is turned off,
    * when exceptions are set.
    */
   @Input() exception?: RegExp;
 
+  @Input()
+  get required(): boolean {
+    return this.#required;
+  }
+  set required(search: BooleanInput) {
+    this.#required = coerceBooleanProperty(search);
+  }
+  #required = false;
+
   touchedFn: any = null;
   changeFn: any = null;
   disabled = false;

diff --git a/libs/ngx-cz-id/tsconfig.lib.json b/libs/ngx-cz-id/tsconfig.lib.json
@@ -12,7 +12,8 @@
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "enableResourceInlining": true,
-    "compilationMode": "partial"
+    "compilationMode": "partial",
+    "strictTemplates": true
   },
   "exclude": ["src/test-setup.ts", "**/*.spec.ts", "**/*.test.ts"],
   "include": ["**\\*.ts"]

diff --git a/package.json b/package.json
@@ -31,6 +31,7 @@
   "private": true,
   "dependencies": {
     "@angular/animations": "13.2.3",
+    "@angular/cdk": "^13.2.4",
     "@angular/common": "13.2.3",
     "@angular/compiler": "13.2.3",
     "@angular/core": "13.2.3",