Skip to content

Commit

Permalink
fix: Fix build + trigger build on test (#43)
Browse files Browse the repository at this point in the history
* fix: Drop mini-css-extract-plugin types

The problem is that those pull broken types for webpack meaning the
project won't build anymore.

* chore: Make sure project gets built on testing

This way we capture build failures.
  • Loading branch information
bebraw authored Oct 20, 2020
1 parent 541d504 commit 054add6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 46 deletions.
44 changes: 0 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"watch": "tsc --watch",
"pretest": "npm run lint",
"test": "npm run test:jest",
"posttest": "npm run format",
"posttest": "npm run format && npm run build",
"lint": "eslint **/*.ts --cache --fix --ignore-path .gitignore",
"format": "prettier --write \"**/*.{ts,md}\"",
"test:jest": "jest",
Expand Down Expand Up @@ -44,7 +44,6 @@
},
"devDependencies": {
"@types/jest": "^26.0.14",
"@types/mini-css-extract-plugin": "^1.0.0",
"@types/webpack-sources": "^2.0.0",
"@typescript-eslint/eslint-plugin": "^2.26.0",
"@typescript-eslint/parser": "^2.26.0",
Expand Down

0 comments on commit 054add6

Please sign in to comment.