From 054add60a433a08dacadb7082f6cbcb5fb249c76 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juho=20Veps=C3=A4l=C3=A4inen?= Date: Tue, 20 Oct 2020 14:18:04 +0200 Subject: [PATCH] fix: Fix build + trigger build on test (#43) * fix: Drop mini-css-extract-plugin types The problem is that those pull broken types for webpack meaning the project won't build anymore. * chore: Make sure project gets built on testing This way we capture build failures. --- package-lock.json | 44 -------------------------------------------- package.json | 3 +-- 2 files changed, 1 insertion(+), 46 deletions(-) diff --git a/package-lock.json b/package-lock.json index d6424fd..05d300e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1041,12 +1041,6 @@ "@sinonjs/commons": "^1.7.0" } }, - "@types/anymatch": { - "version": "1.3.1", - "resolved": "https://registry.npmjs.org/@types/anymatch/-/anymatch-1.3.1.tgz", - "integrity": "sha512-/+CRPXpBDpo2RK9C68N3b2cOvO0Cf5B9aPijHsoDQTHivnGSObdOF2BRQOYjojWTDy6nQvMjmqRXIxH55VjxxA==", - "dev": true - }, "@types/babel__core": { "version": "7.1.10", "resolved": "https://registry.npmjs.org/@types/babel__core/-/babel__core-7.1.10.tgz", @@ -1275,15 +1269,6 @@ "integrity": "sha512-8+KAKzEvSUdeo+kmqnKrqgeE+LcA0tjYWFY7RPProVYwnqDjukzO+3b6dLD56rYX5TdWejnEOLJYOIeh4CXKuA==", "dev": true }, - "@types/mini-css-extract-plugin": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/@types/mini-css-extract-plugin/-/mini-css-extract-plugin-1.0.0.tgz", - "integrity": "sha512-RPwytnqlrfxPvTbASoGr+mVMeGIw8rw2XuyUUFZ8ba+TOAODQLP5E2+4X7VZLB4eV106pJtnBhagOP57hrY5uw==", - "dev": true, - "requires": { - "@types/webpack": "*" - } - }, "@types/node": { "version": "13.9.8", "resolved": "https://registry.npmjs.org/@types/node/-/node-13.9.8.tgz", @@ -1320,35 +1305,6 @@ "integrity": "sha512-RJJrrySY7A8havqpGObOB4W92QXKJo63/jFLLgpvOtsGUqbQZ9Sbgl35KMm1DjC6j7AvmmU2bIno+3IyEaemaw==", "dev": true }, - "@types/tapable": { - "version": "1.0.6", - "resolved": "https://registry.npmjs.org/@types/tapable/-/tapable-1.0.6.tgz", - "integrity": "sha512-W+bw9ds02rAQaMvaLYxAbJ6cvguW/iJXNT6lTssS1ps6QdrMKttqEAMEG/b5CR8TZl3/L7/lH0ZV5nNR1LXikA==", - "dev": true - }, - "@types/uglify-js": { - "version": "3.11.0", - "resolved": "https://registry.npmjs.org/@types/uglify-js/-/uglify-js-3.11.0.tgz", - "integrity": "sha512-I0Yd8TUELTbgRHq2K65j8rnDPAzAP+DiaF/syLem7yXwYLsHZhPd+AM2iXsWmf9P2F2NlFCgl5erZPQx9IbM9Q==", - "dev": true, - "requires": { - "source-map": "^0.6.1" - } - }, - "@types/webpack": { - "version": "4.41.22", - "resolved": "https://registry.npmjs.org/@types/webpack/-/webpack-4.41.22.tgz", - "integrity": "sha512-JQDJK6pj8OMV9gWOnN1dcLCyU9Hzs6lux0wBO4lr1+gyEhIBR9U3FMrz12t2GPkg110XAxEAw2WHF6g7nZIbRQ==", - "dev": true, - "requires": { - "@types/anymatch": "*", - "@types/node": "*", - "@types/tapable": "*", - "@types/uglify-js": "*", - "@types/webpack-sources": "*", - "source-map": "^0.6.0" - } - }, "@types/webpack-sources": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/@types/webpack-sources/-/webpack-sources-2.0.0.tgz", diff --git a/package.json b/package.json index b473dd1..51768ad 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,7 @@ "watch": "tsc --watch", "pretest": "npm run lint", "test": "npm run test:jest", - "posttest": "npm run format", + "posttest": "npm run format && npm run build", "lint": "eslint **/*.ts --cache --fix --ignore-path .gitignore", "format": "prettier --write \"**/*.{ts,md}\"", "test:jest": "jest", @@ -44,7 +44,6 @@ }, "devDependencies": { "@types/jest": "^26.0.14", - "@types/mini-css-extract-plugin": "^1.0.0", "@types/webpack-sources": "^2.0.0", "@typescript-eslint/eslint-plugin": "^2.26.0", "@typescript-eslint/parser": "^2.26.0",