fix: ignore REPL views and Python syntax test files #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
|
Disabling in REPL could be done here but disabling in test files should be done in LSP imo. |
|
Since SublimeREPL is a 3rd-party package, whether we want to support auto disable it in upstream LSP can be discussed. But syntax test is a ST built-in, I think it makes sense to disable that by default in upstream LSP indeed. I've created a related issue in LSP repository: sublimelsp/LSP#2504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
I doubt whether this should be applied generally in upstream LSP or something. Only a very few clients will want to work on those views (e.g., LSP-copilot).