-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update local nodejs and electron runtimes to v18 #103
Conversation
st3/lsp_utils/node_runtime.py
Outdated
ELECTRON_RUNTIME_VERSION = '26.4.0' # includes Node.js v18.16.1 | ||
ELECTRON_NODE_VERSION = '18.16.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also https://github.com/electron/electron/releases/tag/v27.0.0 which includes Node 18.17.1.
Note that I'm thinking of introducing some cleanup code for old versions so I might want to introduce all those changes together. Though I'm not sure how I'll do it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup code might be something for both, the runtime handler and NpmClientHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would need to be somewhat lazy as upon update older releases may still be running and therefore locked on Windows, so removing immediately might fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package updates typically happen on startup and this cleanup would happen before servers are started so it wouldn't be an issue.
It could be an issue when triggering package update manually but then that already can be problematic so I wouldn't worry too much about that. It should correct itself on next start.
node.js v20 LTS is on its way by the end of this month btw. but there is no electron using it at this moment. |
But I suppose it will take Electron quite a while to update to that. |
This PR...