Automated backport of #1447: Fix panic due to invalid nil check #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code results in a panic if the underlying value of 'result'
is nil:
func(result interface{}) (bool, string, error) {
if result == nil {
return false, "gateway not found yet", nil
}
gw := result.(*unstructured.Unstructured)
haStatus := NestedString(gw.Object, "status", "haStatus") => PANIC
...
})
But it first checks if 'result' is nil so how can this be? A simple nil check
does not work because interfaces in Go contain both a type and a value. In
this case, we want to check for nil after casting.
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr1448/tpantelis/automated-backport-of-#1447-upstream-release-0.16 |
sridhargaddam
approved these changes
Oct 31, 2023
maayanf24
approved these changes
Oct 31, 2023
|
🤖 Closed branches: [z_pr1448/tpantelis/automated-backport-of-#1447-upstream-release-0.16] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1447 on release-0.16.
#1447: Fix panic due to invalid nil check
For details on the backport process, see the backport requests page.