Automated backport of #1226: Pin markdownlint-cli version #1228: Pin gitlint version #1499: Fix linting image build failure due to PEP 668 #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unplanned changes in linting requirements that can make it harder to get unrelated patches merged. Relates-to: submariner-io#884 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Avoid unplanned changes in linting requirements that can make it harder to get unrelated patches merged. I looked at removing the need for pip by installing gitlint from the OS, but it's not available in Alpine (it is in Fedora). Relates-to: submariner-io#884 Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
Pip had a check enabled that fails the install due to packages being managed by the OS. The added flag ignores this check. Otherwise, the build fails with: ``` 11.85 × This environment is externally managed 11.85 ╰─> 11.85 The system-wide python installation should be maintained using the 11.85 system package manager (apk) only. ... 11.85 note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages. 11.85 hint: See PEP 668 for the detailed specification. ``` Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam and
tpantelis
as code owners
mkolesnik
approved these changes
Dec 18, 2023
tpantelis
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1226 #1228 #1499 on release-0.13.
#1226: Pin markdownlint-cli version
#1228: Pin gitlint version
#1499: Fix linting image build failure due to PEP 668
For details on the backport process, see the backport requests page.