-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kind OVNK IPV6 deployment #1751
base: devel
Are you sure you want to change the base?
Conversation
🤖 Created branch: z_pr1751/yboaron/ovn_add_ipv6 |
@mkolesnik , QQ: I'm getting [1] error when trying to deploy Kind clusters with OVNK and IPV6 with this PR(with make clusters using=ipv6-stack,ovn), while running directly ./ovn-kubernetes/contrib/kind.sh .... things looks fine, any idea ? [1] |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
🤖 Closed branches: [z_pr1751/yboaron/ovn_add_ipv6] |
🤖 Created branch: z_pr1751/yboaron/ovn_add_ipv6 |
This PR depends on ovn-kubernetes PR [1] [1] ovn-kubernetes/ovn-kubernetes#4955 Signed-off-by: Yossi Boaron <yboaron@redhat.com>
@@ -4,7 +4,7 @@ FROM fedora:41 | |||
# good balance between compression time and resulting image size. | |||
ARG UPX_LEVEL=-5 | |||
ENV DAPPER_HOST_ARCH=amd64 SHIPYARD_DIR=/opt/shipyard SHELL=/bin/bash \ | |||
DAPPER_RUN_ARGS="--net=kind" | |||
DAPPER_RUN_ARGS="--net=kind --cap-add=NET_ADMIN --privileged=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need the extra networking permissions to container for OVN/IPV6 deployment.
@mkolesnik @skitt , is it possible to set DAPPER_RUN_ARGS content based on CNI, IP family env vars ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DAPPER_RUN_ARGS
is a bit of a cheat — it’s not used as an environment variable as such inside the container, so nothing running in the container can set it meaningfully. The .dapper
scripts extracts the value of the variable from the container image before running it.
However since we decide what .dapper
does, anything can be done. Could you explain what the exacts criteria (as in, which values in which files) are and which containers need to run with privileges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For IPV6 OVN deployment (make clusters using=ipv6-stack,ovn) OVN-K script [1] sets net.ipv6.conf.all.forwarding and sudo sysctl -w net.ipv6.conf.all.disable_ipv6 .
so, container should run with net privileges.
[1]
https://github.com/ovn-kubernetes/ovn-kubernetes/blob/master/contrib/kind.sh#L642
Depends on: ovn-kubernetes/ovn-kubernetes#4955