Fix local registry deployments #1808
Merged
+35
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd no longer supports inline registry configuration; files must be created on each node to point to the registry. See kubernetes-sigs/kind#2875 and https://kind.sigs.k8s.io/docs/user/local-registry/ for details. This restores the project's ability to test newly-built images. Signed-off-by: Stephen Kitt <skitt@redhat.com>
This requires handling multiple components for a given container image because the nettest image is used for both the tests and the metrics proxy. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
requested review from
mkolesnik,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1808/skitt/fix-local-registry |
tpantelis
approved these changes
Jan 9, 2025
vthapar
approved these changes
Jan 9, 2025
|
🤖 Closed branches: [z_pr1808/skitt/fix-local-registry] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local registry configuration in containerd has changed, this updates the registry deployment and configuration to match.
In addition, nettest image overrides weren’t handled; this fixes that too.