Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink website/docs/assets/editor-screen.png ? #165

Closed
LauraLangdon opened this issue Aug 18, 2022 · 6 comments · Fixed by #168
Closed

Shrink website/docs/assets/editor-screen.png ? #165

LauraLangdon opened this issue Aug 18, 2022 · 6 comments · Fixed by #168
Assignees
Labels
documentation Anything related to documentation (e.g. doc bugs or similar), *not* documenting new features

Comments

@LauraLangdon
Copy link
Contributor

See #155 (review):

The website/docs/assets/editor-screen.png image still seems huge (over 300k!)... I think we should crop it further, reduce its resolution, and send it through a compressor.

I'm concerned that if it's smaller or lower res it'll be impossible to read. If it doesn't need to be easy to read, I could just remove it instead!

@LauraLangdon LauraLangdon added the documentation Anything related to documentation (e.g. doc bugs or similar), *not* documenting new features label Aug 18, 2022
@flaki
Copy link
Contributor

flaki commented Aug 18, 2022

Oops, just saw this. I believe this shall resolve the issue.

@LauraLangdon
Copy link
Contributor Author

Closed by #155 (comment)

@callahad
Copy link
Contributor

Looks like 2f6c137 pulled in the 68 KB version from Flaki's comment, rather than the further reduction to 28 KB... since the asset is already there, might as well put in the Even Smaller one.

@callahad callahad reopened this Aug 19, 2022
@LauraLangdon
Copy link
Contributor Author

LauraLangdon commented Aug 19, 2022

Looks like 2f6c137 pulled in the 68 KB version from Flaki's comment, rather than the further reduction to 28 KB... since the asset is already there, might as well put in the Even Smaller one.

Ah, I'd used that because I thought I'd understood from Flaki's comment that it was optimized for retina screens, so kind of a lim sup: the smallest size that would still look good on large/high res screens.

It should be roughly ~66KB now, it is a 934x525px@2x image (for retina screens)...

I'll definitely redo it if I misunderstood, ofc @callahad!

@callahad
Copy link
Contributor

Yep! The 28 KB version is exactly the same resolution as Flaki's (and thus equally suitable for retina screens), but compressed slightly more efficiently (8-bit pallet, etc.)

@LauraLangdon
Copy link
Contributor Author

Yep! The 28 KB version is exactly the same resolution as Flaki's (and thus equally suitable for retina screens), but compressed slightly more efficiently (8-bit pallet, etc.)

Got i!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation (e.g. doc bugs or similar), *not* documenting new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants