Skip to content

Commit

Permalink
FIXES ISSUE #3921 Reexamine our default temperament list (#4010)
Browse files Browse the repository at this point in the history
* Updating musicutils.js in order to change the name of the temperament name list 

FIXES ISSUE #3921 Reexamine our default temperament list

* Updating piemenus.js

FIXES ISSUE #3921 Reexamine our default temperament list
In order to fix all the names perfectly in the menu i increased the size of the basic pie menu for the temperament name block
  • Loading branch information
omsuneri authored Sep 23, 2024
1 parent afc3c3f commit 4bafbba
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
3 changes: 3 additions & 0 deletions js/piemenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -2161,6 +2161,9 @@ const piemenuBasic = (block, menuLabels, menuValues, selectedValue, colors) => {
if (block.name === "outputtools" || block.name === "grid") {
// slightly larger menu
size = 1000;
}else if ( block.name === "temperamentname"){
// slightly larger wheel size for the Temperament Menu
size = 1200;
}

// the selectedValueh selector
Expand Down
22 changes: 11 additions & 11 deletions js/utils/musicutils.js
Original file line number Diff line number Diff line change
Expand Up @@ -1554,24 +1554,24 @@ const OSCTYPES = [
* @constant {Array<Array<string>>}
*/
const INITIALTEMPERAMENTS = [
[_("equal"), "equal", "equal"],
[_("just intonation"), "just intonation", "just intonation"],
[_("Pythagorean"), "Pythagorean", "Pythagorean"],
[_("meantone") + " (1/3)", "1/3 comma meantone", "meantone (1/3)"],
[_("meantone") + " (1/4)", "1/4 comma meantone", "meantone (1/4)"]
[_("Equal (12EDO)"), "equal", "equal"],
[_("5-limit Just Intonation"), "just intonation", "just intonation"],
[_("Pythagorean (3-limit JI)"), "Pythagorean", "Pythagorean"],
[_("Meantone") + " (1/3)", "1/3 comma meantone", "meantone (1/3)"],
[_("Meantone") + " (1/4)", "1/4 comma meantone", "meantone (1/4)"]
];

/**
* Array of available temperaments.
* @type {Array<Array<string>>}
*/
let TEMPERAMENTS = [
[_("equal"), "equal", "equal"],
[_("just intonation"), "just intonation", "just intonation"],
[_("Pythagorean"), "Pythagorean", "Pythagorean"],
[_("meantone") + " (1/3)", "1/3 comma meantone", "meantone (1/3)"],
[_("meantone") + " (1/4)", "1/4 comma meantone", "meantone (1/4)"],
[_("custom"), "custom", "custom"]
[_("Equal (12EDO)"), "equal", "equal"],
[_("5-limit Just Intonation"), "just intonation", "just intonation"],
[_("Pythagorean (3-limit JI)"), "Pythagorean", "Pythagorean"],
[_("Meantone") + " (1/3)", "1/3 comma meantone", "meantone (1/3)"],
[_("Meantone") + " (1/4)", "1/4 comma meantone", "meantone (1/4)"],
[_("Custom"), "custom", "custom"]
];

/**
Expand Down

0 comments on commit 4bafbba

Please sign in to comment.