ABC to MB Parser

[abhijeetsingh0401]

Converts ABC file to Music Blocks

[abhijeetsingh0401]

@pikurasa @walterbender there is grace notes which in the code have note taken in consideration could you let me know how we could denote the grace notes(not sure if its hammer on or not ) in MB
https://abcnotation.com/tunePage?a=richardrobinson.tunebook.org.uk/static/tunebook/00526
Line where its breaking due to grace notes

[walterbender]

The easiest thing to do is to ignore them. But what we have done in the past is to put them inside of the note block that they attach to.

[pikurasa]

@pikurasa @walterbender there is grace notes which in the code have note taken in consideration could you let me know how we could denote the grace notes(not sure if its hammer on or not ) in MB
https://abcnotation.com/tunePage?a=richardrobinson.tunebook.org.uk/static/tunebook/00526
Line where its breaking due to grace notes
Uploading image.png…

Those are slur and staccato ornaments.

The third full measure should be translated to the following in MB:

Reference on planet (with scalar transpose, which you may ignore for now): https://musicblocks.sugarlabs.org/index.html?id=1719779740193723&run=True

[walterbender]

A few comments re the code itself:
please use spaces around operators for consistency with the rest of the code base.
Please flag console messages with:
// eslint-disable-next-line no-console

[pikurasa]

@nathannnie this branch would be a good one for you to experiment with.

[abhijeetsingh0401]

@walterbender @pikurasa i have fixed the formatting, could you review this PR

[abhijeetsingh0401]

@walterbender could suggest ways to restructure the code so if we need to consider notation for other things side and pull offs we don't need to write whole thing and debug again

[walterbender]

@abhijeetsingh0401 sorry. I somehow missed this comment. I don't understand what you are asking when you refer to "side and pull offs ". Could you explain with an example?

[abhijeetsingh0401]

Yes I was asking could you let me know is there anyway we could format the could in way that it is to easy handle other edge cases ABC conversion to MB for example in the current PR ABC cases does not handle the cases for slides and pull offs since if we need to handle this whole code needs to be changed and the index of everything is getting changed so it is tough to handle other edge cases

[walterbender]

I don't think it is worthwhile handling some of these corner cases. If there is a slide, we can just render the notes in the slide (and maybe add a "comment" block indicating we are ignoring the slide. I am not familiar with "pull-off" (investigating).

[pikurasa]

I am not familiar with "pull-off" (investigating).

A pull-off is a slur where we go from a higher pitch to a lower pitch. Its opposite is a hammer-on. Those terms are specific to certain string instruments, like guitar, because that's the technical motion required to execute a slur on those instruments.

So, for MB, we should use a legato clamp in those instances.

That being said, I think @abhijeetsingh0401 's question is how to structure the code better to handle conversion of such instances.

[pikurasa]

I think this PR is at a good enough stage in terms of functionality.

We can tackle other functionality improvements in the future.