use object lookup for convertDuration instead of switch #4002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, now the function has better readablity and time complexity:
Object lookup: O(1) average case
Switch statement: O(n) in the worst case, where n is the number of cases
The object lookup is constant-time to the duration mapping, regardless of the input value. Thiss is WAY more efficient, especially for larger sets of cases. and switch statements look unecessarily long in this case.