fix all lint + Base64Encode errors #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A follow up question, I did check out MBV4 When do we just start migrating to MBv4 by making big changes and shift completely, and is it necessary for this version of musicblocks to also run? Just curious |
|
The MBv4 project is inspired by MB but shares no code. A from-the-ground-up rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was using an undefined
base64Encodefunction, causing an error when opening the file on VS Code.Removed the unnecessary
base64Encodefunction call and directly used the built-inwindow.btoa()method for Base64 encoding.Also fixed various EsLint errors. Most were solved by simply using double quotes.
I also removed unused variable names being declared.