Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment pipeline added #4290

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

justin212407
Copy link
Contributor

@justin212407 justin212407 commented Jan 18, 2025

Description:

This PR resolves issue #4284 introducing a GitHub Actions workflow to automate deployment to GitHub Pages. The workflow ensures the main branch is automatically deployed to GitHub Pages on each push or pull request merge.

Changes Made:

Added Deployment Workflow:

A GitHub Actions workflow file was added in .github/workflows/deployment.yml to automate deployment to GitHub Pages. The workflow triggers on push or pull request merge into main and also includes manual deployment support.

Checklist:

  • My changes adhere to the project's contribution guidelines.
  • Code changes are implemented.

justin212407 and others added 3 commits January 18, 2025 13:56
@justin212407
Copy link
Contributor Author

@walterbender I've been working on implementing the CI/CD pipeline for deployment, but the deployment check is failing during the actions/checkout@v2 step with the error: "Input required and not supplied: token." I've ensured the GH_TOKEN secret is configured with the correct permissions (repo, workflow) and referenced in the workflow YAML. I also deployed it on my local branch through github actions and it got deployed there. Despite these, the issue persists. Could you kindly review the workflow file and suggest any changes or fixes to resolve this?

@thebraudalf
Copy link

thebraudalf commented Jan 18, 2025

I think the CI/CD pipeline is already set up for this repository.
Your YAML is configured correctly only for Github pages only.

And to solve this issue they have to write their Environment Variables in YAML secrets.GH_TOKEN.

@justin212407
Copy link
Contributor Author

The CI/CD pipelines setup for this repository do not have deployment file in it. Please refer to the workflows section in the .github folder.

@walterbender
Copy link
Member

I am not sure how the token is supposed to be retrieved. We'll have to dig a bit into this.

@justin212407
Copy link
Contributor Author

What i did was generate a PAT from my account and then i used that to create a secret named GH_TOKEN in my forked repository which i used to here in the code to try and fetch the token. It worked back in my forked repository.

@pikurasa
Copy link
Collaborator

What i did was generate a PAT from my account and then i used that to create a secret named GH_TOKEN in my forked repository which i used to here in the code to try and fetch the token. It worked back in my forked repository.

If it's connected to a user's PAT, how do we collaborate on this?

Does each user user there own? Or do we do some security at the org level. (Please excuse my ignorance.) If there's anything you need at the org level, please let me know.

@justin212407
Copy link
Contributor Author

@pikurasa i am also still looking into why this deployment check is falling apart. As to how i have figured it till now it is probably as you mentioned that it's because of my PAT that this might be not working. I will try to fix it using github token. And i'll definitely contact you if i need anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants