Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbnail service should create multiple thumbnails for embed #26

Closed
ndushay opened this issue Jun 30, 2016 · 7 comments
Closed

thumbnail service should create multiple thumbnails for embed #26

ndushay opened this issue Jun 30, 2016 · 7 comments

Comments

@ndushay
Copy link
Contributor

ndushay commented Jun 30, 2016

@nullhandle says "i believe that this is the component that creates the multiple thumbnails for the embed viewer, not the part that creates the single thumbnail that is included in the object"

"successfully created the single thumbnail, but not (yet anyway) the thumbnails for the embed viewer" (https://argo-stage.stanford.edu/catalog/druid:hz750bw5867)

It should be part of the workflow (I think it is used by the seed robots somewhere)

@ndushay ndushay added the ready label Jun 30, 2016
@ndushay ndushay added this to the fix accessioning worfklows milestone Jun 30, 2016
@aalsum
Copy link
Contributor

aalsum commented Jun 30, 2016

Yes, @ndushay , you are right.

Generating a single thumbnail image for seed object is part of was-seed-preassembly.
https://github.com/sul-dlss/was-seed-preassembly/blob/master/robots/seed/thumbnail_generator.rb

@drh-stanford
Copy link
Contributor

@ndushay ndushay self-assigned this Jul 5, 2016
@ndushay ndushay added in progress and removed ready labels Jul 5, 2016
@ndushay
Copy link
Contributor Author

ndushay commented Jul 5, 2016

See #29 -- it's too big and is now out of scope for "fix accessioning workflows" milestone.

@ndushay ndushay removed this from the fix accessioning worfklows milestone Jul 5, 2016
@drh-stanford
Copy link
Contributor

drh-stanford commented Jul 6, 2016

Here's an example of an 3xx error coming back from : https://swap.stanford.edu/20150412231254id_/http://www.noaa.gov/deepwaterhorizon/

and

https://swap.stanford.edu/20151012231258id_/http
://www.ustr.gov/about-us/press-office/reports-and-publications/

GET https://swap.stanford.edu/20151012231258/http://www.ustr.gov/about-us/press-office/reports-and-publications/
Status  HTTP/1.1 302 Moved Temporarily
Request
Accept  text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
Accept-Encoding gzip, deflate, sdch, br
Accept-Language en-US,en;q=0.8
Cookie  _ga=GA1.2.1345946349.1467053808;
has_js=1;
__utma=154396474.1345946349.1467053808.1467760443.1467760443.1;
__utmc=154396474;
__utmz=154396474.1467760443.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none);
JSESSIONID=6CD2D01EE499033E95CEB75268B9B5ED
Upgrade-Insecure-Requests   1
User-Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36
Response
Connection  Keep-Alive
Content-Length  36536
Content-Type    text/html;charset=utf-8
Date    Wed, 06 Jul 2016 20:16:04 GMT
Keep-Alive  timeout=5, max=100
Link    ; rel="original", ; rel="timemap"; type="application/link-format", ; rel="timegate", ; rel="first memento"; datetime="Sat, 12 Oct 2013 23:12:58 GMT", ; rel="prev memento"; datetime="Sun, 12 Apr 2015 23:13:07 GMT", ; rel="memento"; datetime="Mon, 12 Oct 2015 23:12:58 GMT", ; rel="next last memento"; datetime="Mon, 12 Oct 2015 23:15:36 GMT"
Location    https://swap.stanford.edu/20151012231258/https://ustr.gov/about-us/press-office/reports-and-publications/
Memento-Datetime    Mon, 12 Oct 2015 23:12:58 GMT
Server  Apache-Coyote/1.1
X-Archive-Guessed-Charset   cp1252
X-Archive-Orig-Connection   close
X-Archive-Orig-Content-Length   248
X-Archive-Orig-Content-Type text/html; charset=iso-8859-1
X-Archive-Orig-Date Mon, 12 Oct 2015 23:12:58 GMT
X-Archive-Orig-Location https://ustr.gov/about-us/press-office/reports-and-publications/
X-Archive-Orig-Server   Apache
X-UA-Compatible IE=edge

@ndushay ndushay removed their assignment Dec 8, 2016
@ndushay
Copy link
Contributor Author

ndushay commented Jan 22, 2017

I think this may be addressed by the fix for #15 ???

@ndushay
Copy link
Contributor Author

ndushay commented Jan 22, 2017

However, I am curious:

  • multiple thumbnails show up in embed, and purl but not in argo contentMetadata?

@ndushay
Copy link
Contributor Author

ndushay commented Jan 23, 2017

I am closing this as I believe it is fixed with PR #60.

The bug about redirects is captured as #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants