Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course reserves are now driven from the Folio data #3853

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Course reserves are now driven from the Folio data #3853

merged 1 commit into from
Feb 23, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Feb 1, 2024

Ref #3736

@jcoyne jcoyne marked this pull request as draft February 1, 2024 22:11
@jcoyne jcoyne changed the title Course list Course reserves are now driven from the Folio data Feb 1, 2024
@jcoyne jcoyne force-pushed the course-list branch 2 times, most recently from 48fd2bd to f865dd6 Compare February 6, 2024 22:17
@jcoyne jcoyne marked this pull request as ready for review February 9, 2024 21:57
@jcoyne jcoyne force-pushed the course-list branch 2 times, most recently from 0f6d016 to 2b24a8d Compare February 15, 2024 01:56
@hudajkhan
Copy link
Contributor

Trying this out locally and on staging, the number of courses on the reserves page with FOLIO is 687 while it is 503 in current production. This isn't an error, but just making a note.

When clicking on an individual course reserve link
Current production:
Screenshot 2024-02-16 at 1 13 58 PM

Staging with branch:
Screenshot 2024-02-16 at 1 15 05 PM

Also of note, in production, the URL also includes the instructor facet "&f[instructor][]=Alexander+Nemerov" whereas staging has just the course number. (This may also be fine. Just noting the difference)

In staging, the course reserve red button does not seem to be visible in the search results view as it is in production.

When clicking on item
Current production:
Screenshot 2024-02-16 at 1 17 21 PM

Staging with branch:
Screenshot 2024-02-16 at 1 17 49 PM

@hudajkhan
Copy link
Contributor

Noting a few more differences (these aren't necessarily errors, just differences):

  • The facet label for courses changed in this PR from "course" to "courses_folio_id_ssim" . It may be useful for consistency to keep the same label, but that can be up for discussion.
  • In the example above, the ordering of the courses in an individual page "course reserves" box is different between staging and production, but the same set is represented in both places. This may be a minor difference. In production, in the example above, it seems the list is ordered alphabetically by course number.

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 16, 2024

@hudajkhan I believe the missing red button is because we need this config change to be deployed: sul-dlss/sul-solr-configs#310

Aside from that I believe all the changes were intentional.

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 16, 2024

@dbranchini @saseestone can you speak about what we want to do with the course reserve panel?
Huda correctly pointed out we don't have it sorted by course name, however, in this case this is a single cross listed course. (course listing 46f8e5a3-a407-4277-9cfc-ce9ab0307c8b). Is there some change we want to make to visualize this cross-lising?
Screenshot 2024-02-16 at 3 32 20 PM

@cbeer
Copy link
Member

cbeer commented Feb 20, 2024

I've deployed the solrconfig changes (after figuring out that we were using a special Argo branch of sul-solr-configs....).

I'm pretty sure we don't want to use the facet label "Courses (FOLIO)". Our patrons don't know what FOLIO is. @dbranchini ?

@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 20, 2024

Thanks @cbeer I think I put that there to make it obvious to me, but I forgot to remove it later.

@jcoyne jcoyne force-pushed the course-list branch 2 times, most recently from d035206 to 94cb0cb Compare February 21, 2024 19:35
@jcoyne
Copy link
Contributor Author

jcoyne commented Feb 21, 2024

@hudajkhan it's now sorted by course number:

Screenshot 2024-02-21 at 1 41 13 PM

@cbeer cbeer merged commit bcbc5ac into main Feb 23, 2024
4 checks passed
@cbeer cbeer deleted the course-list branch February 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants