Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated DescriptiveParallelContributor model #532

Open
1 of 2 tasks
ndushay opened this issue Sep 22, 2022 · 6 comments
Open
1 of 2 tasks

remove deprecated DescriptiveParallelContributor model #532

ndushay opened this issue Sep 22, 2022 · 6 comments
Assignees

Comments

@ndushay
Copy link
Contributor

ndushay commented Sep 22, 2022

DescriptiveParallelContributor class is marked deprecated: https://github.com/sul-dlss/cocina-models/blob/main/lib/cocina/models/descriptive_parallel_contributor.rb#L5

https://github.com/sul-dlss/cocina-models/blob/main/openapi.yml#552

Can it be removed?

Arcadia says "parallelContributor was never in use"

Steps

  • write a report to ensure it's not used (if it is, have Arcadia change those objects)
  • take it out of the API and the code (by regenerating models) ... and go through the cocina gem release process.

NOTE that this is the only thing marked deprecated in the cocina-models openapi.yml file

@ndushay ndushay self-assigned this Sep 22, 2022
@ndushay
Copy link
Contributor Author

ndushay commented Sep 22, 2022

no occurences found in DROs or Collections, using property_existence*.rb reports from #4245

@ndushay
Copy link
Contributor Author

ndushay commented Sep 28, 2022

Correction: there are lots of EMPTY occurrences of parallelContributor ...

@justinlittman
Copy link
Contributor

So does that mean this is un-removable?

@jcoyne
Copy link
Collaborator

jcoyne commented Sep 28, 2022

@justinlittman I think we could remove it by making it optional, omitable, and changing the default to nil. Then we can rewrite any/all descriptive metadata that has parallelContributor: []

@ndushay
Copy link
Contributor Author

ndushay commented Sep 28, 2022

I don't think the cost of always putting in empty arrays should be "we can never omit an array property from the model."

@ndushay
Copy link
Contributor Author

ndushay commented Mar 27, 2023

reran reports today; still no non-empty values for parallelContributor for collections or DROs. starting work on PR to

(from JCoyne:)

I think we could remove it by making it optional, omitable, and changing the default to nil. Then we can rewrite any/all descriptive metadata that has parallelContributor: []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants