Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that "Archived website" is valid data #562

Open
jcoyne opened this issue Feb 2, 2023 · 1 comment
Open

Validate that "Archived website" is valid data #562

jcoyne opened this issue Feb 2, 2023 · 1 comment
Labels
question Further information is requested

Comments

@jcoyne
Copy link
Collaborator

jcoyne commented Feb 2, 2023

We're seeing invalid data come to the access side, which is requiring us to validate the data and not display it. Ideally, this bad data would never be sent to us and the content creator would be notified there was a problem when they were accessioning.

sul-dlss/sul-embed#1460

The public XML for https://purl.stanford.edu/qw622dx4390.xml had this:

    <location>
      <url displayLabel="Archived website">https://swap.stanford.edu/was/https://wexarts.org/talks-more/tongues-untied</url>
    </location>

But this URL is required by the viewer to contain /*/

It should look like:

    <location>
      <url displayLabel="Archived website">https://swap.stanford.edu/was/*/https://wexarts.org/talks-more/tongues-untied</url>
    </location>

Please add a validation for this.

In cocina this looks like:

		"access": {
			"url": [{
				"value": "https://swap.stanford.edu/was/*/https://wexarts.org/talks-more/tongues-untied",
				"displayLabel": "Archived website",
			}],
@andrewjbtw
Copy link

I don't think we should use description to store this value. Using this field is a carry over from the Fedora era: sul-dlss/was_robot_suite#279

If we validate this, then the validation should apply only to objects with the content type "webarchive-seed". We shouldn't be constraining description for other content types, as this issue is specific to how the webarchive seed display works.

We should validate whatever field we use to store the link that the timemap depends on.

@ndushay ndushay added the question Further information is requested label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants