Docker2 #2756
Docker2 #2756
Conversation
justinlittman
force-pushed
the
docker2
branch
from
ed32058
to
4043e76
Compare
There was a problem hiding this comment.
For an explanation of some of these changes, see https://github.com/sul-dlss/dlss-capistrano-docker/blob/0d7c1c12e14f02cf0a9e27569098377402796eee/README.md
| @@ -6,7 +6,7 @@ class AssignPidJob | |||
| # This worker will connect to "h2.druid_assigned" queue | |||
| # env is set to nil since by default the actual queue name would be | |||
| # "h2.druid_assigned_development" | |||
| from_queue 'h2.druid_assigned', env: nil | |||
| from_queue Settings.rabbitmq.queues.druid_assigned, env: nil | |||
There was a problem hiding this comment.
All of these queue changes are so that we can run multiple instances of H2 in a single environment and each has its own queue. This will allow us to run a dockerized H2 and a plain-old H2 together.
| @@ -6,8 +6,8 @@ | |||
| # the maximum value specified for Puma. Default is set to 5 threads for minimum | |||
| # and maximum; this matches the default thread size of Active Record. | |||
| # | |||
| max_threads_count = ENV.fetch('RAILS_MAX_THREADS', 5) | |||
| min_threads_count = ENV.fetch('RAILS_MIN_THREADS') { max_threads_count } | |||
| max_threads_count = ENV.fetch('PUMA_MAX_THREADS', 5) | |||
There was a problem hiding this comment.
Changing these variables so that their naming is clearer elsewhere (e.g., in puppet files).
| @@ -9,4 +9,4 @@ | |||
| # Character.create(name: 'Luke', movie: movies.first) | |||
|
|
|||
| # The SDR user is used in Events performed by SDR. | |||
| User.create!(name: 'SDR', email: 'sdr@stanford.edu') | |||
| User.find_or_create_by!(name: 'SDR', email: 'sdr@stanford.edu') | |||
There was a problem hiding this comment.
This allows seeding as part of deploy. Currently, it was performed as a manual operation.
| - HOST | ||
| - HONEYBADGER_API_KEY | ||
| - SETTINGS__RABBITMQ__PASSWORD | ||
| - SETTINGS__RABBITMQ__QUEUES__DEPOSIT_COMPLETE |
There was a problem hiding this comment.
Do we need these *_QUEUES_* variables in here? Aren't they basically constants in settings.yml?
There was a problem hiding this comment.
No, they vary by server so that we can run multiple instances of H2 (e.g., dockerized and non-dockerized) and each has its own queue. This is set in puppet.
justinlittman
force-pushed
the
docker2
branch
4 times, most recently
from
8be10e5
to
090a6f9
Compare
justinlittman
force-pushed
the
docker2
branch
from
090a6f9
to
47cc565
Compare
justinlittman
force-pushed
the
docker2
branch
from
1a51924
to
f052905
Compare
Why was this change made? 🤔
Docker cures all ills.
How was this change tested? 🤨
⚡ ⚠ If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. ⚡