Merge pull request #2275 from sul-dlss/zip-part-size-inconsistency-to…

…-hb-and-event-svc_etc Report ZIP_PARTS_SIZE_INCONSISTENCY to HB and event service, and other smallt touchups
sul-dlss · Oct 23, 2023 · 507fc4d · 507fc4d
2 parents 73fdf73 + 3620f06
commit 507fc4d
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 13 deletions.
diff --git a/app/jobs/validate_moab_job.rb b/app/jobs/validate_moab_job.rb
@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
 # Confirm checksums for one Moab object on storage (not in database)
-# Called from ObjectsController, which is typically called by preservation-robots
-#   in validate-moab step of preservationIngestWF step
+# @note Called from ObjectsController, which is typically called by preservation-robots
+#   in validate-moab step of preservationIngestWF
 # (https://github.com/sul-dlss/workflow-server-rails/blob/main/config/workflows/preservationIngestWF.xml#L18) -
+# For explanation as to why, see comment in preservation_robots Robots::SdrRepo::PreservationIngest::ValidateMoab.
 class ValidateMoabJob < ApplicationJob
   queue_as :validate_moab
 

diff --git a/app/services/audit_reporters/audit_workflow_reporter.rb b/app/services/audit_reporters/audit_workflow_reporter.rb
@@ -25,14 +25,13 @@ def handled_merge_codes
         Audit::Results::MOAB_NOT_FOUND,
         Audit::Results::SIGNATURE_CATALOG_NOT_IN_MOAB,
         Audit::Results::UNABLE_TO_CHECK_STATUS,
-        Audit::Results::UNEXPECTED_VERSION
-        # Temporary fix for workflow-service throwing exceptions
-        # because some error reports from MoabReplicationAudit are too long
-        # ZIP_PART_CHECKSUM_MISMATCH,
-        # ZIP_PART_NOT_FOUND,
-        # ZIP_PARTS_COUNT_DIFFERS_FROM_ACTUAL,
-        # ZIP_PARTS_COUNT_INCONSISTENCY,
-        # ZIP_PARTS_NOT_ALL_REPLICATED
+        Audit::Results::UNEXPECTED_VERSION,
+        Audit::Results::ZIP_PART_CHECKSUM_MISMATCH,
+        Audit::Results::ZIP_PART_NOT_FOUND,
+        Audit::Results::ZIP_PARTS_COUNT_DIFFERS_FROM_ACTUAL,
+        Audit::Results::ZIP_PARTS_COUNT_INCONSISTENCY,
+        Audit::Results::ZIP_PARTS_SIZE_INCONSISTENCY,
+        Audit::Results::ZIP_PARTS_NOT_ALL_REPLICATED
       ].freeze
     end
 

diff --git a/app/services/audit_reporters/event_service_reporter.rb b/app/services/audit_reporters/event_service_reporter.rb
@@ -31,7 +31,8 @@ def handled_merge_codes
         Audit::Results::ZIP_PART_NOT_FOUND,
         Audit::Results::ZIP_PARTS_COUNT_DIFFERS_FROM_ACTUAL,
         Audit::Results::ZIP_PARTS_COUNT_INCONSISTENCY,
-        Audit::Results::ZIP_PARTS_NOT_ALL_REPLICATED
+        Audit::Results::ZIP_PARTS_NOT_ALL_REPLICATED,
+        Audit::Results::ZIP_PARTS_SIZE_INCONSISTENCY
       ].freeze
     end
 

diff --git a/app/services/audit_reporters/honeybadger_reporter.rb b/app/services/audit_reporters/honeybadger_reporter.rb
@@ -14,7 +14,8 @@ def handled_single_codes
         Audit::Results::ZIP_PART_NOT_FOUND,
         Audit::Results::ZIP_PARTS_COUNT_DIFFERS_FROM_ACTUAL,
         Audit::Results::ZIP_PARTS_COUNT_INCONSISTENCY,
-        Audit::Results::ZIP_PARTS_NOT_ALL_REPLICATED
+        Audit::Results::ZIP_PARTS_NOT_ALL_REPLICATED,
+        Audit::Results::ZIP_PARTS_SIZE_INCONSISTENCY
       ].freeze
     end
 

diff --git a/spec/services/audit/checksum_validator_spec.rb b/spec/services/audit/checksum_validator_spec.rb
@@ -486,7 +486,7 @@
 
       before { allow(Audit::Results).to receive(:new).and_return(results) }
 
-      it 'adds a MANIFEST_NOT_IN_MOAB error' do
+      it 'adds a SIGNATURE_CATALOG_NOT_IN_MOAB error' do
         expect(results).to receive(:add_result).with(
           Audit::Results::SIGNATURE_CATALOG_NOT_IN_MOAB, signature_catalog_path: "#{object_dir}/v0002/manifests/signatureCatalog.xml"
         )