Skip to content

Commit

Permalink
Merge pull request #1098 from sul-dlss/add-code-comment
Browse files Browse the repository at this point in the history
add code comment about possible duplication of CORs header code
  • Loading branch information
jcoyne authored Dec 20, 2023
2 parents cda9526 + acfc875 commit 8013a3e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions app/controllers/media_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ def auth_check

private

# TODO: We already globally allow any origin, see
# https://github.com/sul-dlss/stacks/blob/main/app/controllers/application_controller.rb#L11-L19
# So this method, the `before_action` and the `Settings.cors.allow_origin_url` setting may not
# be needed. We may just need to add the `['Access-Control-Allow-Credentials']` header into
# the existing application controller method.
#
# In order for media authentication to work, the wowza server must have
# Access-Control-Allow-Credentials header set (which is set by default when CORS is enabled in wowza),
# which means that Access-Control-Allow-Origin cannot be set to * (wowza default) and instead
Expand Down

0 comments on commit 8013a3e

Please sign in to comment.