Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling dimensions that are too large #1003

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

hudajkhan
Copy link
Contributor

@hudajkhan hudajkhan commented Nov 2, 2023

Closes sul-dlss/sul-embed#1604

What this pull request does:

  • For requests that ask for an explicit width and height combination that is larger than the original image size, this code uses the original image size in the IIIF image request instead.
  • Code already existed to handle restricted images (which relate to user permissions). That code has been updated and repurposed to check for this situation and use the original image size.
  • The type of image class seems to be different between the restricted image use case and these full size image requests. The former has a different method for calculating image size, so the code checks which method is available and uses the appropriate one.

@hudajkhan hudajkhan marked this pull request as ready for review November 3, 2023 04:51
spec/models/projection_spec.rb Outdated Show resolved Hide resolved
@jcoyne jcoyne merged commit f386b1f into main Nov 7, 2023
3 checks passed
@jcoyne jcoyne deleted the handleGreaterDimensions branch November 7, 2023 22:23
jcoyne added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poster should show for video with thumbnail
2 participants