Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert image controller specs to request specs #1058

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Dec 4, 2023

No description provided.

@@ -56,215 +56,293 @@
allow(IiifMetadataService).to receive(:new).and_return(metadata_service)
end

it 'redirects base uri requests to the info.json document' do
get '/image/iiif/nr349ct7889/abc'
context 'with a bare identifier' do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this is just indenting changes. I recommend using "Hide whitespace"

@corylown corylown merged commit 9b03d04 into main Dec 4, 2023
2 checks passed
@corylown corylown deleted the convert_request branch December 4, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants