Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with encoded spaces in filenames #1077

Merged
merged 2 commits into from
Dec 8, 2023
Merged

deal with encoded spaces in filenames #1077

merged 2 commits into from
Dec 8, 2023

Conversation

peetucket
Copy link
Member

@peetucket peetucket commented Dec 8, 2023

  1. When a filename in the URI has spaces in it, they need to be decoded properly (from the encoded filename) before constructing the StacksFile object so that the file can be found on disk.
  2. If the file is not readable on stacks, return a 404 in the status of the response body.

@jcoyne jcoyne merged commit f0ee2ec into main Dec 8, 2023
2 checks passed
@jcoyne jcoyne deleted the probe-service-updates branch December 8, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants