do not throw an exception when attempting to assign a blank publicati…

…on (#1055)

do not throw an exception when attempting to assign a blank publication

app/models/author.rb

@@ -165,6 +165,10 @@ def harvestable?
   # @param [Publication]
   # @return [Contribution]
   def assign_pub(pub)
+    unless pub # do not attempt to assign if no pub provided
+        logger.warn "nil publication assignment for author id #{id}"
+        return
+    end
     raise 'Author must be saved before association' unless persisted?
     pub.contributions.find_or_create_by!(author_id: id) do |contrib|
       contrib.assign_attributes(

spec/models/author_spec.rb

@@ -194,5 +194,15 @@
       # See https://github.com/sul-dlss/sul_pub/issues/1052
       expect(Publication.find(pub.id).pub_hash[:authorship].length).to eq(1)
     end
+
+    it 'does not attempt to assign a blank publication and does not throw an exception' do
+      expect(subject.publications.count).to eq(0)
+      expect(subject.contributions.count).to eq(0)
+
+      subject.assign_pub(nil)
+
+      expect(subject.publications.count).to eq(0)
+      expect(subject.contributions.count).to eq(0)
+    end
   end
 end